Am i a good writer or not?

I write erotica short stories and all of em has five stars..., but most people say I have bad dailogue, grammar, and spelling. Then there are others that simply love everything that is in my stories... I guess my question is, should I keep writing..., or...

should I stop because I'm no good at grammar, spelling, etc?

Grammar and spelling are not so much a problem these days. A lot of tools are free and easy to use get your stories in better shape

You write because you like to write, if other people read it it's just a bonus

Style of writing is very important. Even the story books for children is written in proper English.

How about you prove on your weak areas? Sounds like you do have fans and you cannot quit writing just because of grammatical mistakes.

spelling is not an issue at all, get a friend with good gramma and spelling to read thrue you storys and help you draft them. thats what I do.

I would keep writing, if you really want to write then dont give up. I love to draw sometimes some of the stuff I do isnt so great. but I dont give up because thats what I love to do, its my passion. same way with you if you really love to write no matter what people say dont give up

Use a spellcheck when you write. If 'most' people are telling you it's that bad, then maybe write but don't share them with people. All it will do is get you down if they keep critisising you.